chore: remove the root go.work workspace file - #5814
Conversation
After the webview2 fold (#5711) the workspace covered a single module, ./v3, and every CI workflow already sets GOWORK=off, so it only affected local development. There it did more harm than good: an active workspace shadows the standalone example modules nested under v3/, which is why the mac-window-tabs Taskfiles force GOWORK=off, and it forced CI to run `go work use .` on generated template projects so Go 1.25 workspace mode would not reject them. - delete go.work and go.work.sum - drop the go.work path filters and cache keys from the v3 build and cross-compile workflows - drop the `go work use .` step, which has nothing left to register - gitignore go.work/go.work.sum so local workspaces stay local Verified with `go build ./...` in v3 with no workspace active, and by building a module created at the repo root to confirm nothing rejects it. Claude-Session: https://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8
The webview2 module directory has not existed since it was folded into v3/internal/webview2 (#5711), so the `webview2/**` path filters never match and `webview2/go.sum` never contributes to the Go build cache key. Claude-Session: https://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
WalkthroughV3 CI workflows now use V3-specific path filters and Go cache inputs. Template builds no longer register generated projects with Go workspaces. Local ChangesV3 workspace and CI behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
leaanthony
left a comment
leaanthony
left a comment
There was a problem hiding this comment.
Verified locally: v3 builds with no workspace active, and a module created at the repo root builds without workspace rejection (what the removed go work use . step was compensating for). CI template builds are the real test and are green so far.
The webview2 filter cleanup in the second commit is dead-reference removal from the same lines, no behaviour change.
2 participants
What
Removes the root
go.workworkspace, and the CI plumbing that only existed to support it.After the webview2 fold (#5711) the workspace covered a single module,
./v3, and every CI workflow already setsGOWORK: "off", so it only ever affected local development. There it did more harm than good:v3/. That is whyv3/examples/mac-window-tabshas to forceGOWORK: "off"in two Taskfiles: without it, binding generation finds 0 services andgo mod tidytargets v3 instead.build-and-test-v3.ymlto rungo work use .on each generated template project so Go 1.25 workspace mode would not reject it.Contributors who want a workspace can still create one; it is now gitignored so it stays local.
Changes
go.workandgo.work.sumbuild-and-test-v3.yml: drop thego.work/go.work.sumpath filters, both cache keys, and thego work use .stepcross-compile-test-v3.yml: drop the same filters and cache key.gitignore: ignorego.workandgo.work.summac-window-tabsTaskfiles: keepGOWORK: "off"(still correct defensively, for contributors with a local workspace) but reword the comments, which referred to a root workspace that no longer existsSecond commit, while in the same lines: the
webview2/**path filters andwebview2/go.sumcache entries in both workflows have been dead since the module was folded intov3/internal/webview2. Removed.Verification
go build ./...inv3/with no workspace active: cleango work use .step was compensating forgo workinvocation remains anywhere in the repohttps://claude.ai/code/session_01FigQqUQbNu9ngE4a2CSNm8
Summary by CodeRabbit
Chores
Documentation